Marty Schoch
232fc80dad
add support for phrase slop to internals of phrase searcher
...
phrase slop is not yet supported on the frontend
added lots of tests around slop
2017-02-09 15:59:51 -05:00
Marty Schoch
f82638c117
refactor phrase search to be recursive
...
a more correct solution that will enable us to extend in two
important ways:
1) support slop
2) support multi-phrase
2017-02-03 16:05:21 -05:00
Marty Schoch
12a7257b5f
remove duplicate code suggested by review from @steveyen
2017-01-31 15:12:06 -05:00
Marty Schoch
7fd8aeb50a
refactor phrase search into seprate methods
...
at the core, the Next() method moves another searcher forward
and checks each hit to see if it also satisfies the phrase
constraints. the current implementation has 4 nested for loops.
these nested loops make it harder read (indentation) and harder
to reason about (complexity).
this refactor does not remove any loops, it simply moves some
of the inner loops into separate methods so that one can
more easily reason about the parts separately.
2017-01-31 13:32:46 -05:00
Silvan Jegen
33e2432fc6
Initialize the return value as late as possible
2016-11-08 20:05:36 +01:00
Silvan Jegen
3dd363afaa
Don't search the same term twice
...
We have searched for the first term in the phrase query already so we
can skip it. Before doing so we have to add the location of the first
term.
2016-11-08 20:05:04 +01:00
Silvan Jegen
d87b4f88bf
Refactor phrase searching
...
Reduce nesting by using early continues.
2016-11-08 20:04:28 +01:00
Steve Yen
8230a7195f
some simplification / DRY for phrase searcher
2016-10-12 09:26:31 -07:00
Marty Schoch
3a276153a3
actually rename packages to singular, not just directory name
2016-10-02 10:29:39 -04:00
Marty Schoch
2332455bd2
nicer formatting of license header
2016-10-02 10:13:14 -04:00
Marty Schoch
6bf9dd59ab
BREAKING CHANGE - additional package renaming
...
i recently learned that package names should also prefer the
singular form, not the plural form
2016-10-01 17:20:59 -04:00
