Steve Yen
fd287bdfa4
firestorm.md markdown fixes
2016-01-01 09:57:59 -08:00
Steve Yen
b605224106
use shorter go idiom
2015-12-29 22:14:45 -08:00
Antoine Grondin
6806343677
firestore: fix #296 for division by zero on GC
2015-12-25 11:34:19 +07:00
Antoine Grondin
a6f7abdfa3
firestore: reproducer for division by zero on GC
2015-12-25 11:33:46 +07:00
Marty Schoch
8efbd556a3
fix indexing bug with data coming from arrays
...
fixes #295
2015-12-21 14:59:32 -05:00
Marty Schoch
cf67fe2cbc
fix major synchronization issue in the field_cache
...
The field cache is expected to be the authority on which field
names are identified by which identifier. This code was
optimized for the most common case in which fields already
exist. However, if we deterimine the field is missing with
the read lock (shared), we incorrectly immediately proceed
to create a new row with the write lock (exclusive). The
problem is that multiple goroutines might have come to
the same conclusion, and they all proceed to add rows. The two
choices were to do the whole operation with the write lock, or
recheck the value again with the write lock. We have chosen
to repeat the check inside the write-lock, as this optimizes
for what we believe to be the most common case, in which most
fields will already exist.
2015-12-15 16:39:38 -05:00
Marty Schoch
a73a178923
fix incorrect prefix search behavior
...
avoids double incrementing of end term when reading term dict
fixes #293
2015-12-04 14:07:16 -05:00
Marty Schoch
699c86073a
make existing integration tests work with firestorm
2015-12-01 12:29:56 -05:00
Marty Schoch
6d851cfcc2
fix bug in warmup which led to docs being deleted
2015-11-30 10:18:14 -05:00
Marty Schoch
aa8d98f5fa
include space after prefix in log output
2015-11-30 10:17:48 -05:00
Marty Schoch
68d8742826
correctly prefix internal rows with 'i' and print them in debug
2015-11-30 10:17:15 -05:00
Marty Schoch
c93de9734e
fix issues identified by errcheck
2015-11-24 14:32:33 -05:00
Marty Schoch
bbef1980d8
Merge branch 'master' into firestorm
2015-11-24 13:04:36 -05:00
Marty Schoch
ff11f83842
properly handle errors inside metrics kvstore reporting
2015-11-24 12:52:03 -05:00
Marty Schoch
a707d44e0b
Merge branch 'master' into firestorm
2015-11-24 09:44:47 -05:00
Patrick Mezard
e85c9c542e
row: expose TermFrequencyRow term and freq fields
...
Rows content is an implementation detail of bleve index and may change
in the future. That said, they also contains information valuable to
assess the quality of the index or understand its performances. So, as
long as we agree that type asserting rows should only be done if you
know what you are doing and are ready to deal with future changes, I see
no reason to hide the row fields from external packages.
Fix #268
2015-11-17 17:21:26 +01:00
Kosov Eugene
45e670b99b
BoltDB wrapper nano optimization which makes code a bit prettier too
2015-11-05 00:27:28 +03:00
Marty Schoch
4791625b9b
Merge pull request #262 from pmezard/index-and-tokenizer-doc-and-fix
...
Index and tokenizer doc and fix
2015-11-02 11:51:21 -05:00
Marty Schoch
30651065e9
fix panic on insufficiently sized buffer
...
adds test case to reproduce original problem
fixes #264
2015-10-30 18:25:38 -04:00
Marty Schoch
2bd3ef4080
copy relevant k/v pairs before advancing underlying iterator
2015-10-28 12:23:54 -04:00
Marty Schoch
d1b07f4909
fix dump methods to properly copy keys and values
2015-10-28 12:06:44 -04:00
Marty Schoch
01526e971f
Merge branch 'master' into firestorm
2015-10-28 11:26:01 -04:00
Patrick Mezard
f2b3d5698e
index: document TermFieldReader interface
2015-10-27 18:53:03 +01:00
Patrick Mezard
3df789d258
index: document empty strings behaviour when calling DocIDReader()
2015-10-27 18:53:03 +01:00
Marty Schoch
1a978a4591
fix go vet issues and cleanup reader/iterator
2015-10-26 16:41:58 -04:00
Marty Schoch
f0d282f5f8
add test case for seeing prefix iterators outside of range
...
similar to #256 except for prefix iterators
includes fix for boltdb and gtreap which had incorrect behavior
2015-10-26 16:14:29 -04:00
Patrick Mezard
5100e00f20
doc: DocIDReader.Advance() is no longer implementation dependent
2015-10-20 20:32:23 +02:00
Patrick Mezard
2fa334fc27
doc: talk about "documents" not "indexed or stored documents"
2015-10-20 20:24:24 +02:00
Patrick Mezard
b174c137fd
doc: document DocIDReader, and some Index bits
2015-10-20 20:24:24 +02:00
Patrick Mezard
da72d0c2b9
store_test: deduplicate store initialization
2015-10-20 19:21:01 +02:00
Patrick Mezard
873f483804
gtreap: RangeIterator.Seek should not move before start
2015-10-20 19:12:30 +02:00
Patrick Mezard
5d7628ba3b
boltdb: fix RangeIterator outside of range seeks
...
Two issues:
- Seeking before i.start and iterating returned keys before i.start
- Seeking after the store last key did not invalidate the iterator and
could cause infinite loops.
2015-10-20 19:09:51 +02:00
Patrick Mezard
aada2e7333
store_test: test RangeIterator.Seek on goleveldb
2015-10-20 19:09:38 +02:00
Marty Schoch
6cc21346dc
fix errcheck issues
2015-10-19 14:27:03 -04:00
Marty Schoch
817c317c90
Merge branch 'master' into newkvstore
2015-10-19 12:04:07 -04:00
Marty Schoch
faceecf87b
make row buffer size constant/configurable
...
also handle case where it is insufficiently sized
2015-10-19 12:03:38 -04:00
Marty Schoch
f0ee9a3c66
removed commented code and unused functions
2015-10-19 11:13:03 -04:00
Marty Schoch
c9471d5739
Merge pull request #244 from kevgs/master
...
reducing allocation count
2015-10-16 15:51:30 -04:00
Marty Schoch
e6d0fc8d95
Merge pull request #247 from pmezard/remove-update-goroutine
...
upside_down: no need for a goroutine to enqueue AnalysisWork
2015-10-16 10:15:55 -04:00
Marty Schoch
4c6bc23043
rewrite to keep using same buffer when possible
2015-10-13 14:04:56 -07:00
Marty Schoch
8de860bf12
2 more places that used old Key()
2015-10-13 12:35:08 -07:00
Marty Schoch
5f594d1acc
Merge branch 'master' into newkvstore
2015-10-12 18:07:04 -07:00
Marty Schoch
08572e4925
move literals outside loop for more predicatble test results
2015-10-12 18:06:38 -07:00
Patrick Mezard
8c928539ee
upside_down: no need for a goroutine to enqueue AnalysisWork
...
It boils down to:
1. client sends some work and a notification channel to a single worker,
then waits.
2. worker processes the work
3. worker sends the result to the client using the notification channel
I do not see any problem with this, even with unbuffered channels.
2015-10-12 10:42:14 +02:00
Marty Schoch
95e06538f3
fix benchmarks for the x kvstores
2015-10-09 11:09:42 -04:00
Marty Schoch
0f05d1d3ca
Merge branch 'master' into newkvstore
2015-10-09 10:33:41 -04:00
Patrick Mezard
aee82f8b49
upside_down: simplify return code in batchRows()
2015-10-09 09:57:12 +02:00
Marty Schoch
e28eb749d7
bump up buffer size
2015-10-06 16:45:38 -04:00
Marty Schoch
71cbb13e07
modify code to reuse buffer for kv generation
2015-10-05 17:49:50 -04:00
Kosov Eugene
a61c350888
reducing allocation count
2015-10-05 22:57:10 +03:00
