867110e03b
improvements uncovered some issues with how k/v data was copied or not. to address this, kv abstraction layer now lets impl specify if the bytes returned are safe to use after a reader (or writer since writers are also readers) are closed See index/store/KVReader - BytesSafeAfterClose() bool false is the safe value if you're not sure it will cause index impls to copy the data Some kv impls already have created a copy a the C-api barrier in which case they can safely return true. Overall this yields ~25% speedup for searches with leveldb. It yields ~10% speedup for boltdb. Returning stored fields is now slower with boltdb, as previously we were returning unsafe bytes.
70 lines
1.6 KiB
Go
70 lines
1.6 KiB
Go
// Copyright (c) 2014 Couchbase, Inc.
|
|
// Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file
|
|
// except in compliance with the License. You may obtain a copy of the License at
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
// Unless required by applicable law or agreed to in writing, software distributed under the
|
|
// License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
|
|
// either express or implied. See the License for the specific language governing permissions
|
|
// and limitations under the License.
|
|
|
|
package store
|
|
|
|
type KVBatch interface {
|
|
Set(key, val []byte)
|
|
Delete(key []byte)
|
|
Merge(key []byte, oper AssociativeMerge)
|
|
Execute() error
|
|
Close() error
|
|
}
|
|
|
|
type KVIterator interface {
|
|
SeekFirst()
|
|
Seek([]byte)
|
|
Next()
|
|
|
|
Current() ([]byte, []byte, bool)
|
|
Key() []byte
|
|
Value() []byte
|
|
Valid() bool
|
|
|
|
Close() error
|
|
}
|
|
|
|
type KVStore interface {
|
|
Writer() (KVWriter, error)
|
|
Reader() (KVReader, error)
|
|
Close() error
|
|
}
|
|
|
|
type KVWriter interface {
|
|
KVReader
|
|
Set(key, val []byte) error
|
|
Delete(key []byte) error
|
|
NewBatch() KVBatch
|
|
}
|
|
|
|
type KVReader interface {
|
|
BytesSafeAfterClose() bool
|
|
Get(key []byte) ([]byte, error)
|
|
Iterator(key []byte) KVIterator
|
|
Close() error
|
|
}
|
|
|
|
type AssociativeMerge interface {
|
|
Merge(key, existing []byte) ([]byte, error)
|
|
}
|
|
|
|
type AssociativeMergeChain []AssociativeMerge
|
|
|
|
func (a AssociativeMergeChain) Merge(key, orig []byte) ([]byte, error) {
|
|
curr := orig
|
|
for _, m := range a {
|
|
var err error
|
|
curr, err = m.Merge(key, curr)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
return curr, nil
|
|
}
|