867110e03b
improvements uncovered some issues with how k/v data was copied or not. to address this, kv abstraction layer now lets impl specify if the bytes returned are safe to use after a reader (or writer since writers are also readers) are closed See index/store/KVReader - BytesSafeAfterClose() bool false is the safe value if you're not sure it will cause index impls to copy the data Some kv impls already have created a copy a the C-api barrier in which case they can safely return true. Overall this yields ~25% speedup for searches with leveldb. It yields ~10% speedup for boltdb. Returning stored fields is now slower with boltdb, as previously we were returning unsafe bytes.
104 lines
2.0 KiB
Go
104 lines
2.0 KiB
Go
// Copyright (c) 2014 Couchbase, Inc.
|
|
// Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file
|
|
// except in compliance with the License. You may obtain a copy of the License at
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
// Unless required by applicable law or agreed to in writing, software distributed under the
|
|
// License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
|
|
// either express or implied. See the License for the specific language governing permissions
|
|
// and limitations under the License.
|
|
|
|
package boltdb
|
|
|
|
import (
|
|
"fmt"
|
|
"sync"
|
|
|
|
"github.com/blevesearch/bleve/index/store"
|
|
"github.com/blevesearch/bleve/registry"
|
|
"github.com/boltdb/bolt"
|
|
)
|
|
|
|
const Name = "boltdb"
|
|
|
|
type Store struct {
|
|
path string
|
|
bucket string
|
|
db *bolt.DB
|
|
writer sync.Mutex
|
|
}
|
|
|
|
func Open(path string, bucket string) (*Store, error) {
|
|
rv := Store{
|
|
path: path,
|
|
bucket: bucket,
|
|
}
|
|
|
|
var err error
|
|
rv.db, err = bolt.Open(path, 0600, nil)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
err = rv.db.Update(func(tx *bolt.Tx) error {
|
|
_, err := tx.CreateBucketIfNotExists([]byte(rv.bucket))
|
|
|
|
return err
|
|
})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return &rv, nil
|
|
}
|
|
|
|
func (bs *Store) Close() error {
|
|
return bs.db.Close()
|
|
}
|
|
|
|
func (bs *Store) Reader() (store.KVReader, error) {
|
|
tx, err := bs.db.Begin(false)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return &Reader{
|
|
store: bs,
|
|
tx: tx,
|
|
}, nil
|
|
}
|
|
|
|
func (bs *Store) Writer() (store.KVWriter, error) {
|
|
bs.writer.Lock()
|
|
tx, err := bs.db.Begin(true)
|
|
if err != nil {
|
|
bs.writer.Unlock()
|
|
return nil, err
|
|
}
|
|
reader := &Reader{
|
|
store: bs,
|
|
tx: tx,
|
|
}
|
|
return &Writer{
|
|
store: bs,
|
|
tx: tx,
|
|
reader: reader,
|
|
}, nil
|
|
}
|
|
|
|
func StoreConstructor(config map[string]interface{}) (store.KVStore, error) {
|
|
path, ok := config["path"].(string)
|
|
if !ok {
|
|
return nil, fmt.Errorf("must specify path")
|
|
}
|
|
|
|
bucket, ok := config["bucket"].(string)
|
|
if !ok {
|
|
bucket = "bleve"
|
|
}
|
|
|
|
return Open(path, bucket)
|
|
}
|
|
|
|
func init() {
|
|
registry.RegisterKVStore(Name, StoreConstructor)
|
|
}
|