867110e03b
improvements uncovered some issues with how k/v data was copied or not. to address this, kv abstraction layer now lets impl specify if the bytes returned are safe to use after a reader (or writer since writers are also readers) are closed See index/store/KVReader - BytesSafeAfterClose() bool false is the safe value if you're not sure it will cause index impls to copy the data Some kv impls already have created a copy a the C-api barrier in which case they can safely return true. Overall this yields ~25% speedup for searches with leveldb. It yields ~10% speedup for boltdb. Returning stored fields is now slower with boltdb, as previously we were returning unsafe bytes.
58 lines
1.5 KiB
Go
58 lines
1.5 KiB
Go
// Copyright (c) 2014 Couchbase, Inc.
|
|
// Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file
|
|
// except in compliance with the License. You may obtain a copy of the License at
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
// Unless required by applicable law or agreed to in writing, software distributed under the
|
|
// License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
|
|
// either express or implied. See the License for the specific language governing permissions
|
|
// and limitations under the License.
|
|
|
|
package inmem
|
|
|
|
import (
|
|
"github.com/blevesearch/bleve/index/store"
|
|
)
|
|
|
|
type Writer struct {
|
|
store *Store
|
|
}
|
|
|
|
func newWriter(store *Store) (*Writer, error) {
|
|
store.writer.Lock()
|
|
return &Writer{
|
|
store: store,
|
|
}, nil
|
|
}
|
|
|
|
func (w *Writer) BytesSafeAfterClose() bool {
|
|
return false
|
|
}
|
|
|
|
func (w *Writer) Set(key, val []byte) error {
|
|
return w.store.setlocked(key, val)
|
|
}
|
|
|
|
func (w *Writer) Delete(key []byte) error {
|
|
return w.store.deletelocked(key)
|
|
}
|
|
|
|
func (w *Writer) NewBatch() store.KVBatch {
|
|
return newBatchAlreadyLocked(w.store)
|
|
}
|
|
|
|
func (w *Writer) Close() error {
|
|
w.store.writer.Unlock()
|
|
return nil
|
|
}
|
|
|
|
// these two methods can safely read using the regular
|
|
// methods without a read transaction, because we know
|
|
// that no one else is writing but us
|
|
func (w *Writer) Get(key []byte) ([]byte, error) {
|
|
return w.store.get(key)
|
|
}
|
|
|
|
func (w *Writer) Iterator(key []byte) store.KVIterator {
|
|
return w.store.iterator(key)
|
|
}
|