60750c1614
primary change is going back to sort values be []string
and not []interface{}, this avoid allocatiosn converting
into the interface{}
that sounds obvious, so why didn't we just do that first?
because a common (default) sort is score, which is naturally
a number, not a string (like terms). converting into the
number was also expensive, and the common case.
so, this solution also makes the change to NOT put the score
into the sort value list. instead you see the dummy value
"_score". this is just a placeholder, the actual sort impl
knows that field of the sort is the score, and will sort
using the actual score.
also, several other aspets of the benchmark were cleaned up
so that unnecessary allocations do not pollute the cpu profiles
Here are the updated benchmarks:
$ go test -run=xxx -bench=. -benchmem -cpuprofile=cpu.out
BenchmarkTop10of100000Scores-4 3000 465809 ns/op 2548 B/op 33 allocs/op
BenchmarkTop100of100000Scores-4 2000 626488 ns/op 21484 B/op 213 allocs/op
BenchmarkTop10of1000000Scores-4 300 5107658 ns/op 2560 B/op 33 allocs/op
BenchmarkTop100of1000000Scores-4 300 5275403 ns/op 21624 B/op 213 allocs/op
PASS
ok github.com/blevesearch/bleve/search/collectors 7.188s
Prior to this PR, master reported:
$ go test -run=xxx -bench=. -benchmem
BenchmarkTop10of100000Scores-4 3000 453269 ns/op 360161 B/op 42 allocs/op
BenchmarkTop100of100000Scores-4 2000 519131 ns/op 388275 B/op 219 allocs/op
BenchmarkTop10of1000000Scores-4 200 7459004 ns/op 4628236 B/op 52 allocs/op
BenchmarkTop100of1000000Scores-4 200 8064864 ns/op 4656596 B/op 232 allocs/op
PASS
ok github.com/blevesearch/bleve/search/collectors 7.385s
So, we're pretty close on the smaller datasets, and we scale better on the larger datasets.
We also show fewer allocations and bytes in all cases (some of this is artificial due to test cleanup).
125 lines
3.2 KiB
Go
125 lines
3.2 KiB
Go
// Copyright (c) 2014 Couchbase, Inc.
|
|
// Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file
|
|
// except in compliance with the License. You may obtain a copy of the License at
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
// Unless required by applicable law or agreed to in writing, software distributed under the
|
|
// License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
|
|
// either express or implied. See the License for the specific language governing permissions
|
|
// and limitations under the License.
|
|
|
|
package collectors
|
|
|
|
import (
|
|
"github.com/blevesearch/bleve/document"
|
|
"github.com/blevesearch/bleve/index"
|
|
"github.com/blevesearch/bleve/search"
|
|
)
|
|
|
|
type stubSearcher struct {
|
|
index int
|
|
matches []*search.DocumentMatch
|
|
}
|
|
|
|
func (ss *stubSearcher) Next(ctx *search.SearchContext) (*search.DocumentMatch, error) {
|
|
if ss.index < len(ss.matches) {
|
|
rv := ctx.DocumentMatchPool.Get()
|
|
rv.IndexInternalID = ss.matches[ss.index].IndexInternalID
|
|
rv.Score = ss.matches[ss.index].Score
|
|
ss.index++
|
|
return rv, nil
|
|
}
|
|
return nil, nil
|
|
}
|
|
|
|
func (ss *stubSearcher) Advance(ctx *search.SearchContext, ID index.IndexInternalID) (*search.DocumentMatch, error) {
|
|
|
|
for ss.index < len(ss.matches) && ss.matches[ss.index].IndexInternalID.Compare(ID) < 0 {
|
|
ss.index++
|
|
}
|
|
if ss.index < len(ss.matches) {
|
|
rv := ctx.DocumentMatchPool.Get()
|
|
rv.IndexInternalID = ss.matches[ss.index].IndexInternalID
|
|
rv.Score = ss.matches[ss.index].Score
|
|
ss.index++
|
|
return rv, nil
|
|
}
|
|
return nil, nil
|
|
}
|
|
|
|
func (ss *stubSearcher) Close() error {
|
|
return nil
|
|
}
|
|
|
|
func (ss *stubSearcher) Weight() float64 {
|
|
return 0.0
|
|
}
|
|
|
|
func (ss *stubSearcher) SetQueryNorm(float64) {
|
|
}
|
|
|
|
func (ss *stubSearcher) Count() uint64 {
|
|
return uint64(len(ss.matches))
|
|
}
|
|
|
|
func (ss *stubSearcher) Min() int {
|
|
return 0
|
|
}
|
|
|
|
func (ss *stubSearcher) DocumentMatchPoolSize() int {
|
|
return 0
|
|
}
|
|
|
|
type stubReader struct{}
|
|
|
|
func (sr *stubReader) TermFieldReader(term []byte, field string, includeFreq, includeNorm, includeTermVectors bool) (index.TermFieldReader, error) {
|
|
return nil, nil
|
|
}
|
|
|
|
func (sr *stubReader) DocIDReader(start, end string) (index.DocIDReader, error) {
|
|
return nil, nil
|
|
}
|
|
|
|
func (sr *stubReader) DocIDReaderOnly(ids []string) (index.DocIDReader, error) {
|
|
return nil, nil
|
|
}
|
|
|
|
func (sr *stubReader) FieldDict(field string) (index.FieldDict, error) {
|
|
return nil, nil
|
|
}
|
|
|
|
func (sr *stubReader) FieldDictRange(field string, startTerm []byte, endTerm []byte) (index.FieldDict, error) {
|
|
return nil, nil
|
|
}
|
|
|
|
func (sr *stubReader) FieldDictPrefix(field string, termPrefix []byte) (index.FieldDict, error) {
|
|
return nil, nil
|
|
}
|
|
|
|
func (sr *stubReader) Document(id string) (*document.Document, error) {
|
|
return nil, nil
|
|
}
|
|
|
|
func (sr *stubReader) DocumentFieldTerms(id index.IndexInternalID, fields []string) (index.FieldTerms, error) {
|
|
return nil, nil
|
|
}
|
|
|
|
func (sr *stubReader) Fields() ([]string, error) {
|
|
return nil, nil
|
|
}
|
|
|
|
func (sr *stubReader) GetInternal(key []byte) ([]byte, error) {
|
|
return nil, nil
|
|
}
|
|
|
|
func (sr *stubReader) DocCount() uint64 {
|
|
return 0
|
|
}
|
|
|
|
func (sr *stubReader) FinalizeDocID(id index.IndexInternalID) (string, error) {
|
|
return string(id), nil
|
|
}
|
|
|
|
func (sr *stubReader) Close() error {
|
|
return nil
|
|
}
|