867110e03b
improvements uncovered some issues with how k/v data was copied or not. to address this, kv abstraction layer now lets impl specify if the bytes returned are safe to use after a reader (or writer since writers are also readers) are closed See index/store/KVReader - BytesSafeAfterClose() bool false is the safe value if you're not sure it will cause index impls to copy the data Some kv impls already have created a copy a the C-api barrier in which case they can safely return true. Overall this yields ~25% speedup for searches with leveldb. It yields ~10% speedup for boltdb. Returning stored fields is now slower with boltdb, as previously we were returning unsafe bytes.
48 lines
1.2 KiB
Go
48 lines
1.2 KiB
Go
// Copyright (c) 2014 Couchbase, Inc.
|
|
// Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file
|
|
// except in compliance with the License. You may obtain a copy of the License at
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
// Unless required by applicable law or agreed to in writing, software distributed under the
|
|
// License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND,
|
|
// either express or implied. See the License for the specific language governing permissions
|
|
// and limitations under the License.
|
|
|
|
package boltdb
|
|
|
|
import (
|
|
"github.com/blevesearch/bleve/index/store"
|
|
"github.com/boltdb/bolt"
|
|
)
|
|
|
|
type Reader struct {
|
|
store *Store
|
|
tx *bolt.Tx
|
|
}
|
|
|
|
func (r *Reader) BytesSafeAfterClose() bool {
|
|
return false
|
|
}
|
|
|
|
func (r *Reader) Get(key []byte) ([]byte, error) {
|
|
rv := r.tx.Bucket([]byte(r.store.bucket)).Get(key)
|
|
return rv, nil
|
|
}
|
|
|
|
func (r *Reader) Iterator(key []byte) store.KVIterator {
|
|
b := r.tx.Bucket([]byte(r.store.bucket))
|
|
cursor := b.Cursor()
|
|
|
|
rv := &Iterator{
|
|
store: r.store,
|
|
tx: r.tx,
|
|
cursor: cursor,
|
|
}
|
|
|
|
rv.Seek(key)
|
|
return rv
|
|
}
|
|
|
|
func (r *Reader) Close() error {
|
|
return r.tx.Rollback()
|
|
}
|