From 10fb89a017edb4fe35d87d22f1ff96d79e78c185 Mon Sep 17 00:00:00 2001 From: Gibheer Date: Fri, 14 Dec 2018 14:02:58 +0100 Subject: monwork - readd stringToShellFields This function was needed as bytes.Fields had some problems with the quoting. Now there are test cases too so that errors can be found more easily. --- cmd/monwork/main.go | 37 ++++++++++++++++++++++++++++++++++++- 1 file changed, 36 insertions(+), 1 deletion(-) (limited to 'cmd/monwork/main.go') diff --git a/cmd/monwork/main.go b/cmd/monwork/main.go index d3b852a..81bc347 100644 --- a/cmd/monwork/main.go +++ b/cmd/monwork/main.go @@ -167,7 +167,7 @@ func startConfigGen(db *sql.DB, checkInterval time.Duration) { time.Sleep(checkInterval) continue } - if _, err := tx.Exec(SQLRefreshActiveCheck, check_id, pq.Array(bytes.Fields(cmd.Bytes()))); err != nil { + if _, err := tx.Exec(SQLRefreshActiveCheck, check_id, pq.Array(stringToShellFields(cmd.Bytes()))); err != nil { tx.Rollback() log.Printf("could not refresh check '%d': %s", check_id, err) continue @@ -184,6 +184,41 @@ func startConfigGen(db *sql.DB, checkInterval time.Duration) { } } +func stringToShellFields(in []byte) [][]byte { + if len(in) == 0 { + return [][]byte{} + } + fields := bytes.Fields(in) + result := [][]byte{} + + var quote byte + + for _, field := range fields { + if quote == 0 && (field[0] != '\'' && field[0] != '"') { + result = append(result, field) + continue + } + if quote == 0 && (field[0] == '\'' || field[0] == '"') { + quote = field[0] + if field[len(field)-1] == quote { + result = append(result, field[1:len(field)-1]) + quote = 0 + continue + } + result = append(result, field[1:]) + continue + } + idx := len(result) - 1 + if bytes.HasSuffix(field, []byte{quote}) { + result[idx] = append(result[idx], append([]byte(" "), field[:len(field)-1]...)...) + quote = 0 + continue + } + result[idx] = append(result[idx], append([]byte(" "), field...)...) + } + return result +} + var ( SQLGetConfigUpdates = `select c.id, co.command, c.options from checks c -- cgit v1.2.3-70-g09d2