From e81dff9c07770650b8bf81e30474a0b957316de8 Mon Sep 17 00:00:00 2001 From: Stormwind Date: Sun, 6 Jan 2013 12:37:07 +0100 Subject: Kill all mutants i Zero::Request Fix tests for PATCH, because spec_helper didn't support it and the tests where wrong. Remove if statement from "conent_type", because ruby already returns nil, if the requested key in a hash is not found. (Sounds a bit ugly, but it's true.) --- lib/zero/request.rb | 2 +- spec/spec_helper.rb | 5 +++++ spec/unit/request/patch_spec.rb | 8 ++++---- 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/lib/zero/request.rb b/lib/zero/request.rb index c93bb7e..36ef705 100644 --- a/lib/zero/request.rb +++ b/lib/zero/request.rb @@ -56,7 +56,7 @@ module Zero # TODO change into its own object? # @return [String] returns the content type of the request def content_type - @env[CONST_CONTENT_TYPE] if @env.has_key?(CONST_CONTENT_TYPE) + @env[CONST_CONTENT_TYPE] end # get the media types diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 4a47041..c5605ef 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -40,6 +40,7 @@ class EnvGenerator KEY_REQUEST_POST = 'POST' KEY_REQUEST_PUT = 'PUT' KEY_REQUEST_DELETE = 'DELETE' + KEY_REQUEST_PATCH = 'PATCH' def self.generate_env(uri, options) Rack::MockRequest.env_for(uri, options) @@ -64,4 +65,8 @@ class EnvGenerator def self.delete(uri, options = {}) generate_env(uri, options.merge(KEY_REQUEST_METHOD => KEY_REQUEST_DELETE)) end + + def self.patch(uri, options = {}) + generate_env(uri, options.merge(KEY_REQUEST_METHOD => KEY_REQUEST_PATCH)) + end end diff --git a/spec/unit/request/patch_spec.rb b/spec/unit/request/patch_spec.rb index 1c2d3c9..ae0d2db 100644 --- a/spec/unit/request/patch_spec.rb +++ b/spec/unit/request/patch_spec.rb @@ -3,13 +3,13 @@ require 'spec_helper' describe Zero::Request, '#patch?' do subject { Zero::Request.new(env) } - context "with a post request" do - let(:env) { EnvGenerator.post('/foo') } - its(:post?) { should be(true) } + context "with a patch request" do + let(:env) { EnvGenerator.patch('/foo') } + its(:patch?) { should be(true) } end context "with a get request" do let(:env) { EnvGenerator.get('/foo') } - its(:post?) { should be(false) } + its(:patch?) { should be(false) } end end -- cgit v1.2.3-70-g09d2