From 3a82183563986d368e81b5c314e69f169805fd1f Mon Sep 17 00:00:00 2001 From: Stormwind Date: Sun, 6 Jan 2013 20:24:39 +0100 Subject: Improve test structure Created folder spec/unit/zero and moved all unittest into this folder. --- spec/unit/request/parameter/custom_spec.rb | 23 --------- .../request/parameter/element_reference_spec.rb | 56 ---------------------- spec/unit/request/parameter/initialize_spec.rb | 13 ----- spec/unit/request/parameter/payload_spec.rb | 43 ----------------- spec/unit/request/parameter/query_spec.rb | 25 ---------- 5 files changed, 160 deletions(-) delete mode 100644 spec/unit/request/parameter/custom_spec.rb delete mode 100644 spec/unit/request/parameter/element_reference_spec.rb delete mode 100644 spec/unit/request/parameter/initialize_spec.rb delete mode 100644 spec/unit/request/parameter/payload_spec.rb delete mode 100644 spec/unit/request/parameter/query_spec.rb (limited to 'spec/unit/request/parameter') diff --git a/spec/unit/request/parameter/custom_spec.rb b/spec/unit/request/parameter/custom_spec.rb deleted file mode 100644 index 1abebc9..0000000 --- a/spec/unit/request/parameter/custom_spec.rb +++ /dev/null @@ -1,23 +0,0 @@ -require 'spec_helper' - -describe Zero::Request::Parameter, '#custom' do - subject { Zero::Request::Parameter.new(env) } - let(:env) { EnvGenerator.get('/foo') } - - it 'returns a set custom parameter' do - subject['foo'] = 'bar' - expect(subject.custom['foo']).to eq('bar') - end - - it 'returns the latest set value' do - subject['foo'] = 'first' - subject['foo'] = 'latest' - - expect(subject.custom['foo']).to eq('latest') - end - - it 'is empty if no custom parameter is set' do - expect(subject.custom).to eq({}) - expect(env['zero.params.custom']).to eq({}) - end -end diff --git a/spec/unit/request/parameter/element_reference_spec.rb b/spec/unit/request/parameter/element_reference_spec.rb deleted file mode 100644 index 1136eae..0000000 --- a/spec/unit/request/parameter/element_reference_spec.rb +++ /dev/null @@ -1,56 +0,0 @@ -require 'spec_helper' - -describe Zero::Request::Parameter, '#[]' do - subject { Zero::Request::Parameter.new(env) } - - context 'without parameters' do - let(:env) { EnvGenerator.get('/foo') } - - it 'returns the custom parameter' do - subject['foo'] = 'bar' - expect(subject['foo']).to eq('bar') - end - end - - context 'with query parameters' do - let(:env) { EnvGenerator.get('/foo?foo=bar') } - - it 'returns the query parameter' do - expect(subject['foo']).to eq('bar') - end - - it 'returns the custom parameter' do - subject['foo'] = 'baz' - expect(subject['foo']).to eq('baz') - end - end - - context 'with payload parameters' do - let(:env) do - EnvGenerator.post('/foo', { - :input => 'foo=bar', 'CONTENT_TYPE' => 'multipart/form-data' - }) - end - - it 'returns the payload value' do - expect(subject['foo']).to eq('bar') - end - - it 'returns the custom parameter' do - subject['foo'] = 'baz' - expect(subject['foo']).to eq('baz') - end - end - - context 'with query and payload parameters' do - let(:env) do - EnvGenerator.post('/foo?foo=baz', { - :input => 'foo=bar', 'CONTENT_TYPE' => 'multipart/form-data' - }) - end - - it 'returns the payload parameter' do - expect(subject['foo']).to eq('bar') - end - end -end diff --git a/spec/unit/request/parameter/initialize_spec.rb b/spec/unit/request/parameter/initialize_spec.rb deleted file mode 100644 index 58432cb..0000000 --- a/spec/unit/request/parameter/initialize_spec.rb +++ /dev/null @@ -1,13 +0,0 @@ -require 'spec_helper' - -describe Zero::Request::Parameter, '#initialize' do - subject { Zero::Request::Parameter.new(env) } - let(:env) { EnvGenerator.get('/get', { - 'zero.params.custom' => {'foo' => 'bar'} - }) } - - it 'does not overwrite parameters' do - subject - expect(env['zero.params.custom']).to have_key('foo') - end -end diff --git a/spec/unit/request/parameter/payload_spec.rb b/spec/unit/request/parameter/payload_spec.rb deleted file mode 100644 index 563b21d..0000000 --- a/spec/unit/request/parameter/payload_spec.rb +++ /dev/null @@ -1,43 +0,0 @@ -require 'spec_helper' - -describe Zero::Request::Parameter, '#payload' do - subject { Zero::Request::Parameter.new(env) } - - context 'without parameters' do - let(:env) { EnvGenerator.get('/foo') } - its(:payload) { should == {} } - end - - context 'with a query string' do - let(:env) { EnvGenerator.get('/foo?bar=baz') } - its(:payload) { should == {} } - end - - context 'with a post body' do - let(:env) do - EnvGenerator.post('/foo', { - :input => 'bar=baz', 'CONTENT_TYPE' => 'multipart/form-data' - }) - end - its(:payload) { should == {'bar' => 'baz'} } - end - - context 'with special characters' do - let(:env) do - EnvGenerator.post('/foo', { - :input => 'bar=foo%20bar', 'CONTENT_TYPE' => 'multipart/form-data' - }) - end - its(:payload) { should == {'bar' => 'foo bar'} } - end - - # TODO behaves like this, but is this really good like this? - context 'with a post body and content type application/json' do - let(:env) do - EnvGenerator.post('/foo', { - :input => '"foobar"', 'CONTENT_TYPE' => 'application/json' - }) - end - its(:payload) { should == {} } - end -end diff --git a/spec/unit/request/parameter/query_spec.rb b/spec/unit/request/parameter/query_spec.rb deleted file mode 100644 index 940e80e..0000000 --- a/spec/unit/request/parameter/query_spec.rb +++ /dev/null @@ -1,25 +0,0 @@ -require 'spec_helper' - -describe Zero::Request::Parameter, '#query' do - subject { Zero::Request::Parameter.new(env) } - - context 'without parameters' do - let(:env) { EnvGenerator.get('/foo') } - its(:query) { should == {} } - end - - context 'with a query string' do - let(:env) { EnvGenerator.get('/foo?bar=baz') } - its(:query) { should == {'bar' => 'baz'} } - end - - context 'with a post body' do - let(:env) { EnvGenerator.post('/foo', {:input => 'bar=baz'}) } - its(:query) { should == {} } - end - - context 'with special characters' do - let(:env) { EnvGenerator.get('/foo?bar=foo%20bar') } - its(:query) { should == {'bar' => 'foo bar'} } - end -end -- cgit v1.2.3-70-g09d2