From c341f10ca939a9eb206b37f95357d1ebbde9372d Mon Sep 17 00:00:00 2001 From: Stormwind Date: Sun, 26 Apr 2015 19:11:59 +0200 Subject: [PATCH] Remove not needed abstract classes The constructor classes are not needed for making the library work. So I removed them. --- lib/rubella/input/base.rb | 32 ++------------------------------ 1 file changed, 2 insertions(+), 30 deletions(-) diff --git a/lib/rubella/input/base.rb b/lib/rubella/input/base.rb index f9c2914..a59a2b6 100644 --- a/lib/rubella/input/base.rb +++ b/lib/rubella/input/base.rb @@ -1,42 +1,14 @@ module Rubella module Input - # Gets the rwa data and translate it into a by the Rubella::Weighting::Base - # class readable format. + # Gets the raw data and translate it into a readable format for the + # Rubella::Weighting::Base class. # This must be an array within subarrays, which have all the same lenght # and contains only numeric data. # - # TODO The validation of the data should happen here - # Check if data is array, with subarrays. Check, that all sub array have - # the same size. Check that all the content are numeric values between 0 - # and 100. - # class Base attr_reader :data - # Constructor - # Creates a new Rubella::Input::Base object, from the given data. - # - # @param value string A string, which contains the data - # @return Rubella::Input::Base - # - def self.string value - raise NotImplementedError.new "Please override 'self.string' in your "+ - "concrete implementation" - end - - # Constructor - # Creates a new Rubella::Input::Base object, from the given file. - # Only the file name is required. - # - # @param file_name string The name of the file - # @return Rubella:Input::Base - # - def self.file file_name - raise NotImplementedError.new "Please override 'self.file' in your "+ - "concrete implementation" - end - # Passes each dataset trought the given block. # # @param pointer to block