Merge pull request #766 from steveyen/scorch-persistSnapshot-comment
scorch persistSnapshot comments update
This commit is contained in:
commit
1552caeab9
|
@ -239,8 +239,13 @@ func (s *Scorch) persistSnapshot(snapshot *IndexSnapshot) error {
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// only alter the root if we actually persisted a segment
|
// we need to swap in a new root only when we've persisted 1 or
|
||||||
// (sometimes its just a new snapshot, possibly with new internal values)
|
// more segments -- whereby the new root would have 1-for-1
|
||||||
|
// replacements of in-memory segments with file-based segments
|
||||||
|
//
|
||||||
|
// other cases like updates to internal values only, and/or when
|
||||||
|
// there are only deletions, are already covered and persisted by
|
||||||
|
// the newly populated boltdb snapshotBucket above
|
||||||
if len(newSegmentPaths) > 0 {
|
if len(newSegmentPaths) > 0 {
|
||||||
// now try to open all the new snapshots
|
// now try to open all the new snapshots
|
||||||
newSegments := make(map[uint64]segment.Segment)
|
newSegments := make(map[uint64]segment.Segment)
|
||||||
|
|
Loading…
Reference in New Issue